fix(common): Better support for slug generation when the replacer occurs in the input string #3289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
Thanks! That's a nice improvement. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
normalizeStringfunction doesn't effectively support cases where the replacer itself occurs in the original string.My Product - Complete Collection->my-product---complete-collectionthis PR adjusts the normalizer such that the resultant output is
my-product-complete-collection(i've taken a solitary additional upvote as the go-ahead signal)
Breaking changes
Does this PR include any breaking changes we should be aware of? nup
Screenshots
You can add screenshots here if applicable.
Checklist
📌 Always:
👍 Most of the time: