Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IMM vignette, example data, and updated distribution functions #69

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

GidonFrischkorn
Copy link
Collaborator

This commit adds the vignette for the IMM. Contains two example data sets, and has also included density and random generation functions for the mixture2p, the mixture3p, and the IMM.

Summary

  • Updated the distribution functions for mixture2p, mixture3p, and IMM
  • Added ZhangLuck_2008 and OberauerLin_2017 datasets with documentation
  • Add vignette for the IMM

Tests

[x] Confirm that all tests passed
[x] Confirm that devtools::check() produces no errors

Release notes

  • Updated the distribution functions for mixture2p, mixture3p, and IMM
  • Added ZhangLuck_2008 and OberauerLin_2017 datasets with documentation
  • Add vignette for the IMM

This commit adds the vignette for the IMM. Contains two example data sets, and has also included density and random generation functions for the mixture2p, the mixture3p, and the IMM.
@GidonFrischkorn GidonFrischkorn linked an issue Feb 8, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (06a963c) 64.79% compared to head (17add92) 65.84%.

Files Patch % Lines
R/distributions.R 73.68% 30 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #69      +/-   ##
===========================================
+ Coverage    64.79%   65.84%   +1.04%     
===========================================
  Files           16       16              
  Lines          855      969     +114     
===========================================
+ Hits           554      638      +84     
- Misses         301      331      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@venpopov venpopov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. My only suggestion is to include the figure from Oberauer that you refer to - it's best that the vignette is self-contained. I'll aprove and merge the pull request, and you can push the updated Rmd vignette directly to develop, if you don't change any other code but just add the figure.

@venpopov venpopov merged commit f9c789c into develop Feb 8, 2024
6 checks passed
@venpopov venpopov deleted the 59-add-imm-vignette branch February 8, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add IMM vignette
2 participants