avoid storing transient tasks

vercel · Aug 15, 2024 · fb985a7 · fb985a7
1 parent 5e21bf9
commit fb985a7
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/turbopack/crates/turbo-tasks-backend/src/backend/operation/mod.rs b/turbopack/crates/turbo-tasks-backend/src/backend/operation/mod.rs
@@ -144,7 +144,7 @@ impl<'a> TaskGuard<'a> {
     }
 
     pub fn add(&mut self, item: CachedDataItem) -> bool {
-        if !item.is_persistent() {
+        if self.task_id.is_transient() || !item.is_persistent() {
             self.task.add(item)
         } else if self.task.add(item.clone()) {
             let (key, value) = item.into_key_and_value();
@@ -165,7 +165,7 @@ impl<'a> TaskGuard<'a> {
 
     pub fn insert(&mut self, item: CachedDataItem) -> Option<CachedDataItemValue> {
         let (key, value) = item.into_key_and_value();
-        if !key.is_persistent() {
+        if self.task_id.is_transient() || !key.is_persistent() {
             self.task
                 .insert(CachedDataItem::from_key_and_value(key, value))
         } else if value.is_persistent() {
@@ -209,7 +209,7 @@ impl<'a> TaskGuard<'a> {
         key: &CachedDataItemKey,
         update: impl FnOnce(Option<CachedDataItemValue>) -> Option<CachedDataItemValue>,
     ) {
-        if !key.is_persistent() {
+        if self.task_id.is_transient() || !key.is_persistent() {
             self.task.update(key, update);
             return;
         }
@@ -254,7 +254,7 @@ impl<'a> TaskGuard<'a> {
     pub fn remove(&mut self, key: &CachedDataItemKey) -> Option<CachedDataItemValue> {
         let old_value = self.task.remove(key);
         if let Some(value) = old_value {
-            if key.is_persistent() && value.is_persistent() {
+            if !self.task_id.is_transient() && key.is_persistent() && value.is_persistent() {
                 let key = key.clone();
                 self.task.persistance_state.add_persisting_item();
                 self.backend