Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent scripts from being injected into header #42166

Closed
wants to merge 1 commit into from
Closed

Prevent scripts from being injected into header #42166

wants to merge 1 commit into from

Conversation

ibrahim-ahmed-dev
Copy link

@ibrahim-ahmed-dev ibrahim-ahmed-dev commented Oct 30, 2022

I noticed script tags were being injected into the header element when the head element was not included in the layout, causing a hydration error, this fixes #41953

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

closed the head indexOf
@ibrahim-ahmed-dev ibrahim-ahmed-dev deleted the fix-header-script-inject branch November 2, 2022 19:20
@ibrahim-ahmed-dev
Copy link
Author

Closing as this file is updated now

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Next13] Using <header> tag while no <head> tag is present cause hydration errors.
2 participants