Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inngest example for latest version #68600

Merged
merged 7 commits into from
Aug 15, 2024
Merged

fix: inngest example for latest version #68600

merged 7 commits into from
Aug 15, 2024

Conversation

joelhooks
Copy link
Contributor

This updates the Inngest Next.js example to function with the latest version of the Inngest SDK and generally simplify the structure for demo of the tool.

@joelhooks joelhooks requested review from a team as code owners August 6, 2024 21:35
@joelhooks joelhooks requested review from ismaelrumzan and molebox and removed request for a team August 6, 2024 21:35
@ijjk ijjk added the examples Issue/PR related to examples label Aug 6, 2024
@ijjk
Copy link
Member

ijjk commented Aug 6, 2024

Allow CI Workflow Run

  • approve CI run for commit: 649d946

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Aug 6, 2024

Tests Passed

Copy link

@djfarrelly djfarrelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm from the Inngest team and I have reviewed these changes for accuracy and updates.

Only suggestion @joelhooks is to pin the inngest dependency on 3.x to avoid future breaking changes as well.

@devjiwonchoi
Copy link
Member

@joelhooks The branch is targeted to main, should be canary.
x-ref: https://github.com/vercel/next.js/blob/main/contributing/core/developing.md

@joelhooks joelhooks changed the base branch from main to canary August 12, 2024 12:09
this was requested by Dan
@joelhooks
Copy link
Contributor Author

@devjiwonchoi this PR now properly targets canary

@leerob leerob merged commit 658ffe2 into vercel:canary Aug 15, 2024
36 checks passed
@github-actions github-actions bot added the locked label Sep 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants