Skip to content
This repository has been archived by the owner on Jan 21, 2023. It is now read-only.

Testing @napi-rs/canvas #182

Closed
wants to merge 15 commits into from
Closed

Testing @napi-rs/canvas #182

wants to merge 15 commits into from

Conversation

styfle
Copy link
Member

@styfle styfle commented Jan 6, 2022

No description provided.

@vercel
Copy link

vercel bot commented Jan 6, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/og-image/4YoUcdP1VV57n3wN7Qr91qswPuJb
✅ Preview: https://og-image-git-napirs-canvas.vercel.sh


<path d="M141.68 16.25c-11.04 0-19 7.2-19 18s8.96 18 20 18c6.67 0 12.55-2.64 16.19-7.09l-7.65-4.42c-2.02 2.21-5.09 3.5-8.54 3.5-4.79 0-8.86-2.5-10.37-6.5h28.02c.22-1.12.35-2.28.35-3.5 0-10.79-7.96-17.99-19-17.99zm-9.46 14.5c1.25-3.99 4.67-6.5 9.45-6.5 4.79 0 8.21 2.51 9.45 6.5h-18.9zm117.14-14.5c-11.04 0-19 7.2-19 18s8.96 18 20 18c6.67 0 12.55-2.64 16.19-7.09l-7.65-4.42c-2.02 2.21-5.09 3.5-8.54 3.5-4.79 0-8.86-2.5-10.37-6.5h28.02c.22-1.12.35-2.28.35-3.5 0-10.79-7.96-17.99-19-17.99zm-9.45 14.5c1.25-3.99 4.67-6.5 9.45-6.5 4.79 0 8.21 2.51 9.45 6.5h-18.9zm-39.03 3.5c0 6 3.92 10 10 10 4.12 0 7.21-1.87 8.8-4.92l7.68 4.43c-3.18 5.3-9.14 8.49-16.48 8.49-11.05 0-19-7.2-19-18s7.96-18 19-18c7.34 0 13.29 3.19 16.48 8.49l-7.68 4.43c-1.59-3.05-4.68-4.92-8.8-4.92-6.07 0-10 4-10 10zm82.48-29v46h-9v-46h9zM37.59.25l36.95 64H.64l36.95-64zm92.38 5l-27.71 48-27.71-48h10.39l17.32 30 17.32-30h10.39zm58.91 12v9.69c-1-.29-2.06-.49-3.2-.49-5.81 0-10 4-10 10v14.8h-9v-34h9v9.2c0-5.08 5.91-9.2 13.2-9.2z"></path>

<text fill="url(#rainbow)" fontFamily="Inter">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Brooooooklyn Can the svg font family be used with the GlobalFonts.registerFromPath()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Brooooooklyn It seems like GlobalFonts.registerFromPath() only affects the ctx.fillText() and not the <text> in the svg when using ctx.drawImage().

Is there anyway to make fonts work with ctx.drawImage()? 1887514

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh it may be a bug, I’ll check it asap. You can try to call convertSVGTextToPath before setting svg as Image src. See https://github.com/Brooooooklyn/canvas/blob/main/__test__/svg.spec.ts

Copy link
Member Author

@styfle styfle Jan 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, that worked! Thanks! c3b94c5

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, it seems to be slower than both of the alternatives:

@styfle styfle changed the title Testing napi-rs/canvas Testing @napi-rs/canvas Jan 11, 2022
@styfle
Copy link
Member Author

styfle commented Jan 20, 2023

Closing in favor of #226

@styfle styfle closed this Jan 20, 2023
@styfle styfle deleted the napirs-canvas branch January 20, 2023 23:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants