[ADD] tests for specific uses cases #17
Conversation
There was a problem hiding this comment.
Requires hr_holidays_public_overtime from OCA/hr-holidays#87
|
@albig anything left to do here for merging? |
The PR is fine. But the new requirement for OCA/hr-holidays#87 prevents me from merging (would break my current setup). Any idea how long merging of OCA/hr-holidays#87 will take? |
|
just triggered merging this as it got the ready to merge label. But you really need a setup where you don't have to wait for things to be merged, that's a recipe for frustration, and will slow down your development cycle considerably or just stall it forever. That's why there's git-aggregator, buildout, and all the other ways to stitch together a codebase from a bunch of PRs, I don't think it's possible to do serious development without one of those. |
|
ah, and as you see I'm not even allowed to do this, so we'll have to wait for some of the hr maintainers to merge it |
tests for the use cases you already outlined, I'll work on fixing the public holidays after lunch.
This is designed that adding more uses cases should be very convenient, so let's make extensive use of it.