Improve fontification of variables #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsnyder
reviewed
Sep 13, 2022
| ;; Find the variable name (match-data is set here) | ||
| (setq found-var (re-search-forward verilog-identifier-sym-re limit t)) | ||
| ;; Walk to this variable's delimiter | ||
| (save-match-data |
There was a problem hiding this comment.
I wonder if the save-match-data should be in verilog-forward-ws instead?
There was a problem hiding this comment.
I believe it is already wrapping the last three verilog-forward-ws&directives. I am sorry this diff seems so confusing, it is caused by the indentation changes after adding this condition at the beginning of the function:
(when (and verilog-fontify-variables
(not (member (thing-at-point 'symbol) verilog-keywords)))
wsnyder
reviewed
Sep 13, 2022
* verilog-mode.el (Line#3434, Line#3435, Line#3438, Line#3439, verilog-declaration-varname-matcher): Fix bug in highlighting of vars on func/task arguments. Signed-off-by: Gonzalo Larumbe <[email protected]>
* verilog-mode.el (Line#939, verilog-declaration-varname-matcher, verilog-fontify-variables, verilog-submit-bug-report): Add option to enable/disable variable fontification. Signed-off-by: Gonzalo Larumbe <[email protected]>
gmlarumbe
force-pushed
the
highlight-vars
branch
from
93759aa to
75abe7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR includes 2 commits.
First one fixes a bug in the highlighting of variables inside task and function arguments.
Before the fix:
After the fix:
Second commit adds the variable
verilog-fontify-variablesto enable/disable fontification of variables, as suggested in #1752:The variable
verilog-fontify-variablesdefaults totto keep backwards compatibility.Thanks!