Skip to content

Commit

Permalink
Merge branch 'verji-develop' of https://github.com/verji/matrix-react…
Browse files Browse the repository at this point in the history
…-sdk into rm/1995-invite-dialog
  • Loading branch information
Reza Mohseni committed Aug 22, 2024
2 parents 8c5f697 + 665df7a commit 1d0aa67
Show file tree
Hide file tree
Showing 6 changed files with 46 additions and 22 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/static_analysis.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@ jobs:

i18n_lint:
name: "i18n Check"
if: ${{ github.ref_name != 'verji-develop' }}
# VERJI skip i18n by setting false
if: ${{false}}
uses: matrix-org/matrix-web-i18n/.github/workflows/i18n_check.yml@main
with:
hardcoded-words: "Element"
Expand Down
8 changes: 8 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -206,3 +206,11 @@ Now the yarn commands should work as normal.

We use Playwright and Element Web for end-to-end tests. See
[`docs/playwright.md`](docs/playwright.md) for more information.

// VERJI JTS - change to trigger PR:
1
2
3
4
5
6
31 changes: 22 additions & 9 deletions scripts/ci/install-deps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,23 +9,36 @@

set -ex

scripts/fetchdep.sh matrix-org matrix-js-sdk develop
scripts/fetchdep.sh verji matrix-js-sdk verji-develop # VERJI HARDCODE PARAMS
pushd matrix-js-sdk
[ -n "$JS_SDK_GITHUB_BASE_REF" ] && git fetch --depth 1 origin $JS_SDK_GITHUB_BASE_REF && git checkout $JS_SDK_GITHUB_BASE_REF
yarn link
yarn install --frozen-lockfile $@
popd

scripts/fetchdep.sh matrix-org matrix-analytics-events
#VERJI COMMENT remove matrix-analytics-event
#scripts/fetchdep.sh matrix-org matrix-analytics-events
# We don't pass a default branch so cloning may fail when we are not in a PR
# This is expected as this project does not share a release cycle but we still branch match it
if [ -d matrix-analytics-events ]; then
pushd matrix-analytics-events
yarn link
yarn install --frozen-lockfile $@
yarn build:ts
popd
fi
#if [ -d matrix-analytics-events ]; then
# pushd matrix-analytics-events
# yarn link
# yarn install --frozen-lockfile $@
# yarn build:ts
# popd
#fi
# END VERJI COMMENT

# VERJI ADD custom module-api
scripts/fetchdep.sh verji matrix-react-sdk-module-api verji-main # VERJI HARDCODE PARAMS
pushd matrix-react-sdk-module-api
yarn link
yarn install ## TRY WITHOUT FROZEN --frozen-lockfile $@
yarn build
popd

yarn link @matrix-org/react-sdk-module-api
# VERJI END - custom module-api

yarn link matrix-js-sdk
[ -d matrix-analytics-events ] && yarn link @matrix-org/analytics-events
Expand Down
21 changes: 11 additions & 10 deletions scripts/ci/layered.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,24 +14,25 @@ set -ex
# for the primary repo (react-sdk in this case).

# Set up the js-sdk first
scripts/fetchdep.sh matrix-org matrix-js-sdk develop
scripts/fetchdep.sh verji matrix-js-sdk verji-develop
pushd matrix-js-sdk
[ -n "$JS_SDK_GITHUB_BASE_REF" ] && git fetch --depth 1 origin $JS_SDK_GITHUB_BASE_REF && git checkout $JS_SDK_GITHUB_BASE_REF
yarn link
yarn install --frozen-lockfile
popd

# VERJI COMMENT OUT
# Also set up matrix-analytics-events for branch with matching name
scripts/fetchdep.sh matrix-org matrix-analytics-events
#scripts/fetchdep.sh matrix-org matrix-analytics-events
# We don't pass a default branch so cloning may fail when we are not in a PR
# This is expected as this project does not share a release cycle but we still branch match it
if [ -d matrix-analytics-events ]; then
pushd matrix-analytics-events
yarn link
yarn install --frozen-lockfile
yarn build:ts
popd
fi
# if [ -d matrix-analytics-events ]; then
# pushd matrix-analytics-events
# yarn link
# yarn install --frozen-lockfile
# yarn build:ts
# popd
# fi

# Now set up the react-sdk
yarn link matrix-js-sdk
Expand All @@ -40,7 +41,7 @@ yarn link
yarn install --frozen-lockfile

# Finally, set up element-web
scripts/fetchdep.sh vector-im element-web develop
scripts/fetchdep.sh verji element-web verji-develop
pushd element-web
[ -n "$ELEMENT_WEB_GITHUB_BASE_REF" ] && git fetch --depth 1 origin $ELEMENT_WEB_GITHUB_BASE_REF && git checkout $ELEMENT_WEB_GITHUB_BASE_REF
yarn link matrix-js-sdk
Expand Down
1 change: 1 addition & 0 deletions src/components/views/dialogs/InviteDialog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,7 @@ export default class InviteDialog extends React.PureComponent<Props, IInviteDial
private spaceMemberIds = [] as string[];
// Verji End


public constructor(props: Props) {
super(props);
// Verji Start - generate a list of userId's which are members in currently active space
Expand Down
4 changes: 2 additions & 2 deletions test/components/structures/ViewSource-test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ describe("ViewSource", () => {

expect(() => render(<ViewSource mxEvent={redactedMessageEvent} onFinished={() => {}} />)).not.toThrow();
});

it("should show edit button if we are the sender and can post an edit", () => {
// VERJI SKIP this test because we have disabled the "edit" option
it.skip("should show edit button if we are the sender and can post an edit", () => {
const event = mkMessage({
msg: "Test",
user: MatrixClientPeg.get()!.getSafeUserId(),
Expand Down

0 comments on commit 1d0aa67

Please sign in to comment.