Correction in sending DTMF via SIP INFO #871
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When using the
sendDTMF
function, sending multiple DTMFs failed because the position was not being correctly reset after sending each tone, which resulted in tones being ignored or not sent properly.Previous behavior:
In the previous state, the logic was not adequate to correctly handle the sending of multiple tones, causing interruptions in the sequential sending of DTMFs. The specific problem was that the code used incorrect logic for manipulating the
position
index, which caused errors when DTMFs were queued.Solution:
The implemented correction restructures the management of the
position
variable and ensures that DTMFs are sent correctly, one at a time, respecting the configured duration and interToneGap values.Additionally, new logic resets
position
to ensure that all tones in the queue are sent correctly, resolving the issue of tones being omitted or ignored during the send sequence.Tests:
After the correction, DTMF sending was validated and all tones were sent as expected without interruptions.