Do not run test-asan-undefined in CI Linux GCC and upgrade abseil-cpp to 20240722.0 LTS #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibc
changed the title
ibc
changed the title
nazar-pc
approved these changes
Oct 3, 2024
jmillan
approved these changes
Oct 3, 2024
|
This is insane, no idea what to do about this: https://github.com/versatica/mediasoup/actions/runs/11161680552/job/31024743216?pr=1457 |
I think this command needs the Db_sanitize flag removed: Here |
Good catch, will fix later. |
Later means next week, but it will happen. |
|
CI is green after suggested changes. Thanks @garrettboone. Will release a version soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
test-asan-undefinedin Linux with GCC due to a bug in GCC that affects abseil-cpp: [Bug]: Constexpr expansion compilation error with GCC's UndefinedBehaviorSanitizer abseil/abseil-cpp#1634