Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial effort to use IPC calls to control verso #207

Merged
merged 5 commits into from
Oct 24, 2024
Merged

Initial effort to use IPC calls to control verso #207

merged 5 commits into from
Oct 24, 2024

Conversation

Legend-Master
Copy link
Contributor

No description provided.

@Legend-Master Legend-Master mentioned this pull request Oct 23, 2024
Open
17 tasks
@Legend-Master Legend-Master marked this pull request as ready for review October 23, 2024 11:53
wusyong
wusyong reviewed Oct 24, 2024
View reviewed changes
Copy link
Member

@wusyong wusyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you create main.rs instead of simple.rs example?
I think it can showcase how to build it into verso browser as well.

wusyong
wusyong reviewed Oct 24, 2024
View reviewed changes
src/config.rs Outdated Show resolved Hide resolved
wusyong
wusyong reviewed Oct 24, 2024
View reviewed changes
src/verso.rs Outdated Show resolved Hide resolved
@wusyong wusyong added this pull request to the merge queue Oct 24, 2024
Merged via the queue into versotile-org:main with commit 3843d4e Oct 24, 2024
6 checks passed
@Legend-Master Legend-Master deleted the versoview-controller branch October 24, 2024 06:40
@Legend-Master Legend-Master mentioned this pull request Nov 11, 2024
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wusyong wusyong wusyong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Legend-Master @wusyong