Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(window): drag resize window #208

Merged
merged 8 commits into from
Oct 24, 2024
Merged

feat(window): drag resize window #208

merged 8 commits into from
Oct 24, 2024

Conversation

pewsheen
Copy link
Collaborator

No description provided.

@pewsheen pewsheen requested a review from wusyong as a code owner October 23, 2024 08:08
Copy link
Member

@wusyong wusyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder is it possible to do this in panel? I mean creating some div around the frame to detect if it needs to send drag event.

@pewsheen
Copy link
Collaborator Author

I wonder is it possible to do this in panel? I mean creating some div around the frame to detect if it needs to send drag event.

It's possible, but I think that won't be necessary and may be inefficient since events are doing a round-trip, and it will spam events between verso and webview.

We'll need to check the pointer move event when the pointer is on the DIV and constantly report to Verso to change the cursor icon. Also, the DIV may block the interaction of some DOM elements under it, increasing the maintenance effort to avoid those elements being overlapped.

Copy link
Member

@wusyong wusyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Let's keep current plan then.

@wusyong wusyong added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit decf3b3 Oct 24, 2024
6 checks passed
@wusyong wusyong deleted the resize-window branch October 24, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants