feat: implement fixed context menu for mac and windows #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 21, 2024 13:46
wusyong
reviewed
Nov 11, 2024
wusyong
reviewed
Nov 11, 2024
wusyong
reviewed
Nov 11, 2024
src/lib.rs
Outdated
| @@ -29,3 +29,6 @@ pub use errors::{Error, Result}; | |||
| pub use verso::Verso; | |||
| /// Re-exporting Winit for the sake of convenience. | |||
| pub use winit; | |||
| /// Context | |||
| #[cfg(any(target_os = "macos", target_os = "windows"))] | |||
There was a problem hiding this comment.
Maybe we can add stub for linux. It can be easier for future implementation.
pewsheen
force-pushed
the
poc-context-menu
branch
from
06a2606 to
1cc7395
Compare
wusyong
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #225
This PR implements a very first prototype of a context menu that shows only
back,forwardandreloadoptions.The structure should be improved once we solved issues from Servo and Wayland popup