Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow enable and set profiler settings from cli #235

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

Legend-Master
Copy link
Contributor

No description provided.

@Legend-Master Legend-Master mentioned this pull request Nov 14, 2024
17 tasks
@Legend-Master Legend-Master marked this pull request as ready for review November 14, 2024 13:51
Copy link
Member

@wusyong wusyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you give a sample on what you get from setting time profiler?

src/config.rs Show resolved Hide resolved
src/config.rs Outdated Show resolved Hide resolved
Co-authored-by: Ngo Iok Ui (Wu Yu Wei) <[email protected]>
Signed-off-by: Tony <[email protected]>
@Legend-Master
Copy link
Contributor Author

Output from using --profiler=5

PS C:\tt\verso> cargo run -- --profiler=5
   Compiling versoview v0.0.1 (C:\tt\verso)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.30s
     Running `target\debug\versoview.exe --profiler=5`
Running on AMD Radeon RX 6600
OpenGL Version 3.3.0 Core Profile Context 24.10.1.241007
Shaders version on 4.60
_category_                          _incremental?_ _iframe?_             _url_                  _mean (ms)_   _median (ms)_      _min (ms)_      _max (ms)_       _events_ 
Compositing                             N/A          N/A                  N/A                        5.2734          0.3778          0.0032         58.3003              24
Layout                                  no           yes     https://example.com/                    4.7785          4.7785          4.7785          4.7785               1
Layout                                  yes          yes     verso://panel.html                      3.4018          2.6053          1.8499         12.7874              12
Layout                                  no           yes     verso://panel.html                     15.8592         15.8592         15.8592         15.8592               1
Script JS Evaluate                      no           yes     verso://panel.html                      0.9780          0.9780          0.9780          0.9780               1
Script Parse HTML                       no           yes     https://example.com/                    5.0000          5.0179          4.9821          5.0179               2
Script Parse HTML                       no           yes     verso://panel.html                     55.9050         62.2433         49.5667         62.2433               2
Time To First Paint                     no           yes     https://example.com/                    0.0000          0.0000          0.0000          0.0000               1
Time To First Paint                     yes          yes     verso://panel.html                      0.0000          0.0000          0.0000          0.0000               1
Time To First Paint                     no           yes     verso://panel.html                      0.0000          0.0000          0.0000          0.0000               1
Time To First Contentful Paint          no           yes     https://example.com/                    0.0000          0.0000          0.0000          0.0000               1
Time To First Contentful Paint          yes          yes     verso://panel.html                      0.0000          0.0000          0.0000          0.0000               1

_url_   _blocked layout queries_

When profiler-output-file is used, the output will be saved to that file instead when exiting verso
When profiler-trace-path is used, a self-contained HTML timeline of profiler traces will be saved to that file when exiting verso

@wusyong wusyong added this pull request to the merge queue Nov 14, 2024
Merged via the queue into versotile-org:main with commit 2650e80 Nov 14, 2024
6 checks passed
@Legend-Master Legend-Master deleted the profiler-cli-support branch November 14, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants