Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dialog): add HTTP basic authentication #263

Merged
merged 3 commits into from
Jan 7, 2025
Merged

feat(dialog): add HTTP basic authentication #263

merged 3 commits into from
Jan 7, 2025

Conversation

pewsheen
Copy link
Collaborator

@pewsheen pewsheen commented Dec 30, 2024 •
edited
Loading

Remaining issues:

  • Canceled prompt keeps showing up and hang (switch tabs and back will fix it) fixed
  • After a bad authentication, it'll still fail even if you enter the correct account info (should fix in servo)
  • Credential prompts in servo blocks other tabs webview process (should fix in servo)

@alerque
Copy link

alerque commented Dec 30, 2024

You know, just the Basics.

@pewsheen pewsheen marked this pull request as ready for review January 6, 2025 04:51
@pewsheen pewsheen requested a review from wusyong as a code owner January 6, 2025 04:51
@wusyong wusyong added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit da288df Jan 7, 2025
6 checks passed
@wusyong wusyong deleted the feat/dialog-http-basic-auth branch January 7, 2025 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wusyong wusyong wusyong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pewsheen @alerque @wusyong