-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update servo to c070372
#269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to set servo config prefs when new Verso, it requires remapping CSS prefs now.
servo_config::prefs::set(preferences);
I think we can just new a default Preference and enable flexbox then we can remove prefs.json as well.
@@ -32,8 +35,6 @@ pub struct CliArgs { | |||
pub no_panel: bool, | |||
/// Window settings for the initial winit window | |||
pub window_attributes: WindowAttributes, | |||
/// Port number to start a server to listen to remote Firefox devtools connections. 0 for random port. | |||
pub devtools_port: Option<u16>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this removal? Servo changed devtools_port
from Opts
to Preferences
, we should set it on Preferences
instead of removing this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With corresponding settings moved to Preference means we have to consciously have a new component maintaining preference if we want to keep these.
We can add them back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With corresponding settings moved to Preference means we have to consciously have a new component maintaining preference if we want to keep these.
I'm not sure what do you mean, can't we just change
servo_config::prefs::set(Preferences::default());
to
servo_config::prefs::set(Preferences {
devtools_server_port: ...,
devtools_server_enabled: ...,
..Default::default()
});
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, we can just add it back like that for now. It is just removed for the sake of updating servo and the fact that we currently don't have preference differences from servo.
Accompanying the change of
servo
preferences, several changes has been made:resources/prefs.json
as we don't have difference from defaultservo
at the moment