Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(panel): support navigate to url, close #72 #76

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Conversation

pewsheen
Copy link
Collaborator

@pewsheen pewsheen commented Jul 4, 2024

@pewsheen pewsheen requested a review from wusyong as a code owner July 4, 2024 10:01
@pewsheen
Copy link
Collaborator Author

pewsheen commented Jul 4, 2024

CleanShot.2024-07-04.at.18.06.35.mp4

Copy link
Member

@wusyong wusyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you extend the documentation in panel too?
https://github.com/versotile-org/verso/blob/main/src/webview.rs#L42

@pewsheen
Copy link
Collaborator Author

pewsheen commented Jul 4, 2024

Can you extend the documentation in panel too? https://github.com/versotile-org/verso/blob/main/src/webview.rs#L42

done

@wusyong wusyong added this pull request to the merge queue Jul 4, 2024
Merged via the queue into main with commit 9bebec6 Jul 4, 2024
6 checks passed
@wusyong wusyong deleted the feat/navigate-url branch July 23, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support navigation in panel's navigation bar
2 participants