Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Swagger-Core to generate the OpenAPI file on the fly #412

Open
wants to merge 5 commits into
base: 4.x
Choose a base branch
from

Conversation

gerardnico
Copy link

Motivation:

I have added Swagger-Core in the example.
The rest easy 4.0.0 example was not working already. I got an issue over unknown function.
I have downgraded it to 3.8. I know this is a 4.0 branch.

Conformance:

No problem to conform and to sign whatever is needed.

Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

@vietj
Copy link
Contributor

vietj commented Jan 14, 2021

@gerardnico how can we solve this version mismatch ?

@gerardnico
Copy link
Author

I can put it back to 4.0.0 but it will not work.
This is just to alert on the fact that this example was not working in 4.0.0.

I can put it back to 4.0.0 but I does not have the vertx core knowledge to resolve it.
I got a function not known if I remember well.

@gerardnico
Copy link
Author

I just saw that you were already at 3.9.5. I made the update and added a test.

The error that I get with 4.0.0 is:

SEVERE: Unhandled exception
java.lang.NoSuchMethodError: io.vertx.core.http.HttpServerRequest.rawMethod()Ljava/lang/String;
	at org.jboss.resteasy.plugins.server.vertx.VertxRequestHandler.lambda$handle$0(VertxRequestHandler.java:56)
	at io.vertx.core.impl.future.FutureImpl$1.onSuccess(FutureImpl.java:91)
	at io.vertx.core.impl.future.FutureBase.lambda$emitSuccess$0(FutureBase.java:53)
	at io.vertx.core.impl.EventLoopContext.execute(EventLoopContext.java:83)

@gerardnico
Copy link
Author

This commit 99194a9 resolve a bug. The template engine expects the vertx object but because it was static, it got a null object
The other just get rid of the static cache which is annoying when you are going through the examples.

@vietj
Copy link
Contributor

vietj commented Jan 18, 2021

what does not work with 4.0.0 ? can you elaborate what is blocking you ?

@gerardnico
Copy link
Author

I already did yesterday and I understand that it's confusing.

The stack trace is

SEVERE: Unhandled exception
java.lang.NoSuchMethodError: io.vertx.core.http.HttpServerRequest.rawMethod()Ljava/lang/String;
	at org.jboss.resteasy.plugins.server.vertx.VertxRequestHandler.lambda$handle$0(VertxRequestHandler.java:56)
	at io.vertx.core.impl.future.FutureImpl$1.onSuccess(FutureImpl.java:91)
	at io.vertx.core.impl.future.FutureBase.lambda$emitSuccess$0(FutureBase.java:53)
	at io.vertx.core.impl.EventLoopContext.execute(EventLoopContext.java:83)

This is an error with the RestEasy Plugin that expects HttpServerRequest.html#rawMethod and can't found it anymore in 4.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants