cache parsed request body buffer #1356
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmlopes
reviewed
Aug 28, 2019
| @@ -67,6 +68,9 @@ | |||
| private Set<FileUpload> fileUploads; | |||
| private Session session; | |||
| private User user; | |||
| private JsonArray parsedBodyAsJsonArray; | |||
| private JsonObject parsedBodyAsJson; | |||
| private Map<String, String> parsedBodyAsString; | |||
There was a problem hiding this comment.
Isn't it an overkill to cache all encodings? Why not just cache the default encoding "null" and extract from the buffer other encodings? A new map here will just create gc as I guess most users will not switch encodings during a request that often, wdyt?
There was a problem hiding this comment.
@pmlopes I'm not sure I understand your point...
I agree that on the same request context, the same encoding will probably be used (on most cases) over and over again.
What do you suggest? removing the cache by encoding map?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.