#1648 Populate headers from RequestOptions in WebClient.request() #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcinus
changed the title
gaol
reviewed
Jun 30, 2020
| @@ -197,7 +197,8 @@ public WebClientBase(HttpClient client, WebClientOptions options) { | |||
| @Override | |||
| public HttpRequest<Buffer> request(HttpMethod method, SocketAddress serverAddress, RequestOptions requestOptions) { | |||
| return new HttpRequestImpl<>(this, method, serverAddress, requestOptions.isSsl(), requestOptions.getPort(), | |||
| requestOptions.getHost(), requestOptions.getURI(), BodyCodecImpl.BUFFER, options); | |||
| requestOptions.getHost(), requestOptions.getURI(), BodyCodecImpl.BUFFER, options) | |||
| .putHeaders(requestOptions.getHeaders()); | |||
There was a problem hiding this comment.
requestOptions.getHeaders() is possible null
|
I think adding a test would be easier to get merged. :) |
vietj
reviewed
Jul 1, 2020
vertx-web-client/src/main/java/io/vertx/ext/web/client/impl/WebClientBase.java
Outdated
Show resolved
Hide resolved
|
LGTM if @marcinus can squash into one commit :) |
…ent.request() Signed-off-by: Marcin Szymura <[email protected]>
marcinus
force-pushed
the
bugfix/1648-webclient-headers
branch
from
f7ce37e to
9e84bda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
#1648
Conformance:
Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines