Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding logs #975

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding logs #975

wants to merge 1 commit into from

Conversation

BrunoVernay
Copy link
Contributor

slinkydeveloper
slinkydeveloper requested changes Jun 11, 2019
View reviewed changes
Copy link
Member

@slinkydeveloper slinkydeveloper left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For each log statement you must do the if to check the log level

vertx-web/src/main/java/io/vertx/ext/web/handler/impl/OAuth2AuthHandlerImpl.java
@@ -30,6 +30,8 @@
import io.vertx.ext.web.Session;
import io.vertx.ext.web.handler.AuthHandler;
import io.vertx.ext.web.handler.OAuth2AuthHandler;
import io.vertx.core.logging.Logger;
import io.vertx.core.logging.LoggerFactory;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you switch log imports to io.vertx.core.impl.logging?

@slinkydeveloper
Copy link
Member

Can you rebase with latest master changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slinkydeveloper slinkydeveloper slinkydeveloper requested changes

@recena recena recena approved these changes

Assignees
No one assigned
Labels
to review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BrunoVernay @slinkydeveloper @recena @pmlopes