Add line number in comments for some functions (to support Mariposa's Verus integration features) #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utaal
requested changes
Jul 26, 2023
source/rust_verify/src/verifier.rs
Outdated
| @@ -591,7 +591,7 @@ impl Verifier { | |||
| qid_map: &HashMap<String, vir::sst::BndInfo>, | |||
| module: &vir::ast::Path, | |||
| function_name: Option<&Fun>, | |||
| comment: &str, | |||
| comment: (&str, &str), | |||
There was a problem hiding this comment.
Can you take the span as a new parameter instead, and stringify it here instead? This way we cannot forget to add it if we add new calls to run_commands_queries.
There was a problem hiding this comment.
I think the commit below should fix this problem! Turns out commands_with_context contains the span information I needed, so no span information needs to be passed into run_commands_queries.
turns out i didn't need to take span in as a parameter; there is a span variable in the function that i can use also prevents the "forgetting to put &span.as_string" issue
|
Can you please run |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is intended to make it easier for Mariposa to determine the original location of unstable Verus queries from their corresponding SMT2 files.
Specifically, the additional comment is for queries labeled as Function-Defs, Function-Decl-Check-Recommends, and Function-Terminations.
Ex:
A similar comment is already present in some SMT2 files generated by Verus, but the comment only appears in queries that use the spinoff prover:
Ex: