Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR performs two changes:
calc
calc
to behave as relations (==>
and<==>
)(1) is needed to support (2). In particular, the older version of calc assumed that each relation was a single token (or at least denoted via a single
tt
); unfortunately, operators like==>
and<==>
are composed of multiple tokens. Thus, to support them, we need to carefully thread through repetitions oftt
s across the whole of the calc macro. This is what (1) does.(2) then simply adds the minor additions. In fact, now that (1) is done, adding new relations should be as easy as this second one.
From a user-facing perspective, (1) should have no change at all, and (2) should start allowing
calc
to be used in more places.To review this PR, it is likely easiest to read the commits for (1) and (2) separately.
Also, reminder to self: don't squash-and-commit (instead just rebase both commits); keeping these two commits separate will make it easier to understand how to add new operators to
calc
.