Skip to content

Commit

Permalink
Merge pull request #33294 from vespa-engine/hmusum/minor-logging-chan…
Browse files Browse the repository at this point in the history
…ges-2

Minor logging changes
  • Loading branch information
hakonhall authored Feb 11, 2025
2 parents c0a9514 + d0ff8a5 commit 25a7e92
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ public Optional<File> getFileDownloadIfNeeded(FileReferenceDownload fileReferenc
return file;

if (fileReferenceDownload.downloadFromOtherSourceIfNotFound()) {
log.log(Level.FINE, "File not found, downloading from another source");
log.log(Level.FINE, fileReferenceDownload + " not found, downloading from another source");
// Create new FileReferenceDownload with downloadFromOtherSourceIfNotFound set to false
// to avoid requesting a file reference perpetually, e.g. for a file that does not exist anymore
FileReferenceDownload newDownload = new FileReferenceDownload(fileReference,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,8 @@ private boolean startDownloadRpc(FileReferenceDownload fileReferenceDownload, in
return false;
}
} else {
log.log(logLevel, "Downloading " + fileReference + " from " + address + " failed:" +
log.log(logLevel, "Downloading " + fileReference + " from " + address +
" (client " + fileReferenceDownload.client() + ") failed:" +
" error code " + request.errorCode() + " (" + request.errorMessage() + ")." +
" (retry " + retryCount + ", rpc timeout " + timeout + ")");
return false;
Expand Down

0 comments on commit 25a7e92

Please sign in to comment.