implement matched-elements-only for indexed arrays #33285
+142
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toregge
previously approved these changes
Feb 9, 2025
| @@ -30,6 +30,28 @@ namespace search::fef { | |||
|
|
|||
| namespace proton::matching { | |||
|
|
|||
| class FieldIdToNameMapper { | |||
There was a problem hiding this comment.
Consider moving thisclass to a separate header file.
| @@ -30,6 +30,28 @@ namespace search::fef { | |||
|
|
|||
| namespace proton::matching { | |||
|
|
|||
| class FieldIdToNameMapper { | |||
| public: | |||
| const std::string & lookup(uint32_t fieldId) const { | |||
There was a problem hiding this comment.
Consider deinlining the implementation of lookup
| } | ||
| return lookupFailed; | ||
| } | ||
| uint32_t lookup(const std::string& fieldName) const { |
There was a problem hiding this comment.
This version of lookup appears to be unused. Consider removing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@toregge please review
@havardpe please review
@geirst FYI
Note: this won't work for weighted set terms.