Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop to master - search bar bug fix & UI fixes #2107

Merged
merged 11 commits into from
Apr 23, 2019
Merged

Develop to master - search bar bug fix & UI fixes #2107

merged 11 commits into from
Apr 23, 2019

Conversation

SupeDeDupe
Copy link
Contributor

@SupeDeDupe SupeDeDupe commented Apr 23, 2019

Closes #2104, reopens #1368. The #1368 bug is preferable over #2104. The solution may require some refactoring of the search string in redux. I currently do not know and was not able to find where the search string in redux is updated when the searchString url param is set.

This PR also closes #2044.

@thomascraig thomascraig temporarily deployed to vac-benefit-directory-pr-2107 April 23, 2019 12:25 Inactive
@SupeDeDupe SupeDeDupe temporarily deployed to vac-benefit-directory-pr-2107 April 23, 2019 12:37 Inactive
@SupeDeDupe SupeDeDupe temporarily deployed to vac-benefit-directory-pr-2107 April 23, 2019 14:47 Inactive
@SupeDeDupe SupeDeDupe changed the title Develop to master - search bar bug fix Develop to master - search bar bug fix & UI fixes Apr 23, 2019
@SupeDeDupe SupeDeDupe merged commit 7e34f93 into master Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search string is limited to one word Buttons need to be updated.
2 participants