Feat/avif convertion #334
Merged
Feat/avif convertion #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paulijuz
previously approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Love the new image collection admin menu!
From some quick testing everything seems to work fine. I have just a few comments, but they all can be fixed at a later date.
- Why can't I upload avif (or webp for that matter) images? I mean the images are going to be converted to avif anyway...
- Some text starts with lowercase letters when they should start with uppercase and some text is in english when it should be in Norwegian
- It's not really clear from a ux perspective what name a picture will get when the "bruk filnavn som navn" toggle switch is off.
- If I edit the metadata of a picture and press
escthe picture popup closes instead of the metadata popup. Afterwards I cannot close the metadata popup no matter what I do.
|
I'll open for more formats |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts all images to avif on upload. We know have three image sizes + original. This PR also fixes: