Refactor/docker base config #388
Open
+217
−240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paulijuz
requested review from
JohanHjelsethStorstad and
theodorklauritzen
and removed request for
JohanHjelsethStorstad and
theodorklauritzen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing tests it became clear that having three different docker files is hard to maintain as all of the shared services have to specified three places. Especially when the env variables to the pn container would be annoying to maintain as changing it would mean changing it three places. This PR fixes it by adding a third (fourth with tests) docker compose file (
docker-compose.base.yml) which contains all the shared services. Then the specific compose file (dev, test or prod) uses theextendskeyword to use the service from the shared file and applies the required modifications, for example exposing different ports or using different volumes.This PR also adds a skeleton for the docker file for tests. The testing framework itself will be implemented in another PR.
Also, I have added the npm run commants
docker:dev,docker:test, anddocker:prodfor simplifying starting up docker. I don't expect people to use them, but they might be useful for some newcomers if they find it hard to remember the exact command to start the project. The commands for dev and test also automatically copy the.env.defaultfile.