-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use assert_allclose instead of np.allclose and np.isclose(...).all() #115
Conversation
…e rtol=1e-7, atol=0 in remaining np.allclose tests
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
==========================================
- Coverage 90.94% 90.86% -0.08%
==========================================
Files 30 30
Lines 2616 2617 +1
Branches 501 501
==========================================
- Hits 2379 2378 -1
- Misses 136 137 +1
- Partials 101 102 +1
|
LMK if the changes are OK for you, else the commits can be reverted. |
doc-build issue is likely due to joblib/joblib#1457 |
The documentation build issue will be fixed when mne-tools/mne-python#11756 lands on main. Or we can build the documentation using EDIT: MNE 1.5 is almost out, so it will be fixed soon. |
@vferat This PR is good to go. Don't bother reviewing the changes (since they are mostly due to the black autorun), but instead the bullet points bellow and let me know if you want me to revert/change anything:
If that's all good for you, I'll merge and then update #112 and fix the conflicts before reviewing. |
That's all good for me, I'll let you do the merge 👍 |
Fixes #114
Also change to
assert_allclose
which has a saneratol=0
argument + better logging/error information when failing.Waiting now for tests to run, check that everything is still green.
After, WDYT about changing black to the default 88 character per line to match MNE? (it's a bit annoying to change the ruler position in the IDE 😉)