Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup automation hallway #415

Merged
merged 12 commits into from
Aug 24, 2023
Merged

Setup automation hallway #415

merged 12 commits into from
Aug 24, 2023

Conversation

mvgijssel
Copy link
Member

@mvgijssel mvgijssel commented Jul 2, 2023

ref #110

  • Ensure transition time is at least twice active time human sensor
  • Ensure door occupancy is max 3 seconds by reducing motion sensor timeout
  • The state transition calculation needs to be separate from trigger specific logic
  • Means all motion sensors need to be installed on the opposite side of the door how the door opens to better ensure motion is always triggered

@mvgijssel
Copy link
Member Author

mvgijssel commented Jul 3, 2023

Thoughts:

  1. If transition time is shorter than human timeout state remains present
  2. If door occupancy change is missed then room is left in wrong state. This can happen with an open door and motion not being triggered.
  3. If state changes to absent and door occupancy is still happening then a new change to entering is missed.
  4. If the door occupancy change lasts long then transition is possible
    • present -> leaving -> absent -> entering -> absent
    • absent -> entering -> present
  5. To prevent flipping between states a "leave" transition needs to hold for a particular time?
  6. What to do when door occupancy is still going when switching states?

@mvgijssel mvgijssel enabled auto-merge (squash) August 24, 2023 13:33
@mvgijssel mvgijssel merged commit e5c3918 into master Aug 24, 2023
2 checks passed
@mvgijssel mvgijssel deleted the mg/380/setup-automation-hallway branch August 24, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant