Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify hiearchy for path graphs #25

Closed
wants to merge 1 commit into from
Closed

Conversation

glennhickey
Copy link
Contributor

I'm not a super huge fan of the MutablePathMutableHandleGraph. In practice this going to be one of our goto classes. Do we really need the Mutable specifier twice? Here's a proposal:

  • Get rid of MutablePathMutableHandleGraph and MutablePathDeletableHandleGraph
  • MutablePathHandleGraph now means the Graph and Path is mutable
  • Add DeletablePathHandleGraph which likewise had deletable paths and graph

This makes the header files less modular, but as discussed in #16, we probably don't want to move forward with cross-products of features.

@glennhickey
Copy link
Contributor Author

AHA, I finally used MutablePathHandleGraph with only one Mutable:

https://github.com/vgteam/vg/blob/master/src/augment.hpp#L61-L65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant