Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-3050: Add fusionauth instructions #3894

Merged
merged 9 commits into from
Jan 24, 2025
Merged

Conversation

npentrel
Copy link
Collaborator

@npentrel npentrel commented Jan 22, 2025

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Jan 22, 2025
Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit 622177a
🔍 Latest deploy log https://app.netlify.com/sites/viam-docs/deploys/6793e7fc14cc560008929620
😎 Deploy Preview https://deploy-preview-3894--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 26 (🟢 up 2 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@npentrel npentrel force-pushed the fusionauth branch 2 times, most recently from 2d4e3c7 to 06bb684 Compare January 22, 2025 21:52
@npentrel npentrel requested a review from maxhorowitz January 22, 2025 21:55
@maxhorowitz
Copy link
Member

1. logo-path --> --logo-path

Screenshot 2025-01-22 at 5 59 12 PM

2. Maybe we can add an example with more than one URL as a comma-separated list for an argument?

Not sure where this would go ... maybe the "Click to view more information about arguments." area?

3. We also added the option to delete, should this be included too?

viam organization auth-service oauth-app delete

Copy link
Member

@maxhorowitz maxhorowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the super duper clear docs very happy with how this is turning out !

3 main comments - and with fresh eyes tomorrow will see if I can find anything else. Thanks again - I'll check back tomorrow morning on this thread.

@npentrel
Copy link
Collaborator Author

Made updates for 1 & 2. The delete command is covered in the CLI docs.

I created a new app today because I got errors this morning that I didn't have the right permissions for the org I was using yesterday. The new app I created is not showing the Google & Apple login. Do you have an idea why that might be?

@viambot
Copy link
Member

viambot commented Jan 23, 2025

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3894

@maxhorowitz maxhorowitz self-requested a review January 23, 2025 22:18
Copy link
Member

@maxhorowitz maxhorowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Google + Apple SSO thing was realized yesterday, just ticketed it now: https://viam.atlassian.net/browse/APP-7499. It's a one day ticket and can be remedied manually in the meantime.

As for the docs, they look great! One question I had is why we nest "You must have owner permissions on the organization." inside of the "organization set logo" step, when in reality its required for all of the OAuth commands (except maybe "list") - though I can confirm this. What do you think?

@npentrel
Copy link
Collaborator Author

Ok sounds good. It's with the the logo one because that's the first step. Tbf it may not really need to be specified at all. The error message speaks for itself I think so mentioning it once on the side is probably good enough

Copy link
Collaborator

@sguequierre sguequierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm couple minor comments

docs/dev/tools/cli.md Outdated Show resolved Hide resolved
docs/dev/tools/cli.md Outdated Show resolved Hide resolved
docs/manage/manage/oauth.md Outdated Show resolved Hide resolved
Co-authored-by: Sierra Guequierre <[email protected]>
docs/dev/tools/cli.md Outdated Show resolved Hide resolved
npentrel and others added 2 commits January 24, 2025 20:17
Co-authored-by: Sierra Guequierre <[email protected]>
Co-authored-by: Sierra Guequierre <[email protected]>
docs/manage/manage/oauth.md Outdated Show resolved Hide resolved
docs/manage/manage/oauth.md Outdated Show resolved Hide resolved
docs/manage/manage/oauth.md Outdated Show resolved Hide resolved
docs/manage/manage/oauth.md Outdated Show resolved Hide resolved
docs/manage/manage/oauth.md Outdated Show resolved Hide resolved
docs/manage/manage/oauth.md Outdated Show resolved Hide resolved
docs/manage/manage/oauth.md Outdated Show resolved Hide resolved
@npentrel npentrel merged commit d51686a into viamrobotics:main Jan 24, 2025
12 checks passed
@npentrel npentrel deleted the fusionauth branch January 24, 2025 19:23
Copy link

🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs (https://docs.viam.com)'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants