-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-3050: Add fusionauth instructions #3894
Conversation
✅ Deploy Preview for viam-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2d4e3c7
to
06bb684
Compare
1.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the super duper clear docs very happy with how this is turning out !
3 main comments - and with fresh eyes tomorrow will see if I can find anything else. Thanks again - I'll check back tomorrow morning on this thread.
Made updates for 1 & 2. The delete command is covered in the CLI docs. I created a new app today because I got errors this morning that I didn't have the right permissions for the org I was using yesterday. The new app I created is not showing the Google & Apple login. Do you have an idea why that might be? |
You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3894 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Google + Apple SSO thing was realized yesterday, just ticketed it now: https://viam.atlassian.net/browse/APP-7499. It's a one day ticket and can be remedied manually in the meantime.
As for the docs, they look great! One question I had is why we nest "You must have owner permissions on the organization." inside of the "organization set logo" step, when in reality its required for all of the OAuth commands (except maybe "list") - though I can confirm this. What do you think?
Ok sounds good. It's with the the logo one because that's the first step. Tbf it may not really need to be specified at all. The error message speaks for itself I think so mentioning it once on the side is probably good enough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm couple minor comments
Co-authored-by: Sierra Guequierre <[email protected]>
Co-authored-by: Sierra Guequierre <[email protected]>
Co-authored-by: Sierra Guequierre <[email protected]>
🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs (https://docs.viam.com)' |
https://deploy-preview-3894--viam-docs.netlify.app/manage/manage/oauth/