RSDK-9896: Allow anyone to attach PeerConnections to contexts. (#411)

viamrobotics · Feb 3, 2025 · a03938d · a03938d
1 parent cf6c56e
commit a03938d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/rpc/context.go b/rpc/context.go
@@ -45,8 +45,8 @@ func contextDialer(ctx context.Context) Dialer {
 	return dialer.(Dialer)
 }
 
-// contextWithPeerConnection attaches a peer connection to the given context.
-func contextWithPeerConnection(ctx context.Context, pc *webrtc.PeerConnection) context.Context {
+// ContextWithPeerConnection attaches a peer connection to the given context.
+func ContextWithPeerConnection(ctx context.Context, pc *webrtc.PeerConnection) context.Context {
 	return context.WithValue(ctx, ctxKeyPeerConnection, pc)
 }
 

diff --git a/rpc/context_test.go b/rpc/context_test.go
@@ -31,7 +31,7 @@ func TestContextDialer(t *testing.T) {
 func TestContextPeerConnection(t *testing.T) {
 	ctx := context.Background()
 	var pc webrtc.PeerConnection
-	ctx = contextWithPeerConnection(ctx, &pc)
+	ctx = ContextWithPeerConnection(ctx, &pc)
 	_, ok := ContextPeerConnection(context.Background())
 	test.That(t, ok, test.ShouldBeFalse)
 	pc2, ok := ContextPeerConnection(ctx)

diff --git a/rpc/wrtc_server_channel.go b/rpc/wrtc_server_channel.go
@@ -127,7 +127,7 @@ func (ch *webrtcServerChannel) onChannelMessage(msg webrtc.DataChannelMessage) {
 		} else {
 			handlerCtx, cancelCtx = context.WithTimeout(handlerCtx, timeout)
 		}
-		handlerCtx = contextWithPeerConnection(handlerCtx, ch.peerConn)
+		handlerCtx = ContextWithPeerConnection(handlerCtx, ch.peerConn)
 
 		// TODO(GOUT-11): Handle auth; right now we assume successful auth to the signaler
 		// implies that auth should be allowed here, which is not 100% true.