-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RSDK-9754] Remove webcam discovery logic #4720
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is webcam_e2e_test ran anywhere in CI? Is this the one we saw didn't run a while back with Julie?
Also thanks for the @ I will note the merge conflicts that inevitably arise in #4604
Nope! I Want me to remove the e2e test as well? |
wtf happened here I tried to merge THESE changes into my branch but I think it went both ways |
It is perfectly okay I can deal with the conflicts - still waiting for the discovery card to be in - which should be tomorrow! |
It's ok I can revert it to the previous commit. (sigh time to go back to |
2d5cf42
to
a00c1bc
Compare
OK I did what I set out to do, which is to merge these changes into #4604 and test & update aforementioned PR to be ready for review and merge after this one is merged (to avoid conflicts). |
In an effort to make RSDK-9630 slightly smaller - I broke out the webcam Discovery removal into its own work since it is isolated.
I tested the app on my Mac - nothing broke. We get no response in the video_path field and it connects to the first camera it finds.
I will wait until we have a discovery card to merge this in.
The replacement find-cameras module
TODO: