UpdateFragment/ ListFragments - add visibility parameter #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
piokasar
commented
Jul 15, 2024
•
piokasar
commented
- Added optional fragmentVisibility list in listFragments
- Added optional fragmentVisibility in updateFragment
piokasar
requested review from
njooma and
purplenicole730
and removed request for
njooma and
purplenicole730
piokasar
force-pushed
the
add-visibility-field
branch
from
980fc35 to
9567f81
Compare
piokasar
force-pushed
the
add-visibility-field
branch
8 times, most recently
from
41427b7 to
97ba780
Compare
piokasar
force-pushed
the
add-visibility-field
branch
from
97ba780 to
347e257
Compare
njooma
requested changes
Jul 16, 2024
lib/src/app/app.dart
Outdated
| Future<List<Fragment>> listFragments(String organizationId, bool showPublic) async { | ||
| final request = ListFragmentsRequest() | ||
| Future<List<Fragment>> listFragments(String organizationId, bool showPublic, {List<FragmentVisibility>? fragmentVisibility}) async { | ||
| final request = ListFragmentsRequest(fragmentVisibility: fragmentVisibility) |
There was a problem hiding this comment.
Can you please switch this to the ..fragmentVisiblity = fragmentVisibility syntax like the other options?
There was a problem hiding this comment.
ok, actually should be good to go now - had to use addAll since it's an iterable
piokasar
force-pushed
the
add-visibility-field
branch
2 times, most recently
from
1251efb to
3916636
Compare
piokasar
force-pushed
the
add-visibility-field
branch
from
3916636 to
eb2d9f3
Compare
piokasar
force-pushed
the
add-visibility-field
branch
from
eb2d9f3 to
2feec74
Compare
purplenicole730
approved these changes
Jul 16, 2024
njooma
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.