Start mdns after setting listeners #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuqdog
approved these changes
Dec 12, 2024
acmorrow
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
I don't know enough about dart to take a position on the details of the code, but this does seem to bring it into alignment with the documented way of using the API. I also tested this locally, and with this change in place, a flutter app is able to discover a micro-rdk instance via mDNS running in the same isolated network, and then connect to it with WebRTC. Without this change, it doesn't ever manage to discover it.
LGTM and thanks for the quick fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the docs, you need to start mDNS AFTER setting listeners