Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-9622: Add Discover Service and GetModelsFromModules to Flutter #321

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

RSDK-9622: Add Discover Service and GetModelsFromModules to Flutter #321

wants to merge 8 commits into from

Conversation

martha-johnston
Copy link
Contributor

No description provided.

@martha-johnston
Copy link
Contributor Author

I think these won't pass until api is updated, which will happen with this PR

@martha-johnston martha-johnston marked this pull request as ready for review January 10, 2025 21:49
@martha-johnston martha-johnston requested a review from a team as a code owner January 10, 2025 21:49
@martha-johnston
Copy link
Contributor Author

I'm unsure why some of these tests aren't passing, specifically the failures related to vision, because I didn't make any vision changes.

purplenicole730
purplenicole730 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@purplenicole730 purplenicole730 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with the Flutter SDK so you might want to wait on Naveed's approval as well, but lgtm at a first glance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purplenicole730 purplenicole730 purplenicole730 approved these changes

@njooma njooma Awaiting requested review from njooma njooma is a code owner automatically assigned from viamrobotics/sdk-netcode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martha-johnston @purplenicole730