Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix package.json import for webpack5 compatibility #148

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

barronbud
Copy link

Description

When using Webpack 5 this warning is thrown during builds:

videojs-contrib-quality-levels/src/plugin.js @ 30:33-40
Should not import the named export 'version' (imported as 'VERSION') from default-exporting module (only default export is available soon)

This updates importing package.json and updates the version references in plugin.js.

Specific Changes proposed

  • Import package.json as full object named packageInfo and reference accordingly

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Unit Tests updated or fixed
    • Docs/guides updated
  • Reviewed by Two Core Contributors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant