Collect vargs parameter #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michieljoris
commented
Nov 24, 2023
| ?msg-fmt (let [format-specifiers (count-format-specifiers ?msg-fmt) | ||
| [message vargs] (split-at format-specifiers vargs) | ||
| message (String/format ?msg-fmt (to-array message)) | ||
| args (if (and (= 1 (count vargs)) |
There was a problem hiding this comment.
This bypasses logic in collect-vargs
Michieljoris
commented
Nov 24, 2023
| key-names default-key-names}}] | ||
| key-names default-key-names | ||
| msg-key (:msg key-names) | ||
| level-key (:level key-names) |
There was a problem hiding this comment.
Get defaults for msg-key and level-key from key-names which falls back to default-key-names
Michieljoris
force-pushed
the
collect-vargs-parameter
branch
from
b7ad608 to
4e280db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes hardcoding of msg-key and level-key in the install fn and allows the use of a custom collect-vargs fn so that for instance only last arg (if a map) to a log fn will be added as args to the json map.