-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#33] twig tailwind prettier #58
Draft
joshuapease
wants to merge
43
commits into
5.x
Choose a base branch
from
jp/33-twig-tailwind-prettier
base: 5.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses `vite-plugin-static-copy` to copy SVGs from src/icons Macro inlines SVG files into page.
- Adds TW class for default site max width
- Uses both image & icon cards
- Update cards & buttons to use new window.
- Simple is just Bold, Italic, Underline plus links - Advanced has more options like headings, styles, lists, etc.
Whoops :)
The nav has a max depth of 3 levels. This simplifies our markup since it doesn't have to be recursive
The desktop and mobile nav markup will be their own partials.
Instead of using a focus trap, we focus on the first element in the sub nav, but allow you to tab out of the list. When focus leaves, we pop the subnav.
TODO: Still needc to sort out how to get TW to work with .twig extension
Base automatically changed from
jp/51-header-and-footer
to
jp/45-page-blocks-and-sections
December 18, 2024 13:52
Base automatically changed from
jp/45-page-blocks-and-sections
to
jp/44-base-ui-elements
December 18, 2024 13:53
joshuapease
force-pushed
the
5.x
branch
2 times, most recently
from
January 17, 2025 14:50
ed9b9f8
to
6f1bd23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An experimental branch to test the Twig Prettier extension.
TODO: Still need to sort out how to get Tailwind Formatting to work with .twig extension