Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement cleaner page refresh when page is clicked #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LordDarkula
Copy link
Contributor

Use location.reload() js function for a cleaner reload.
Also made other minor improvements such as deleting unused id tags.

@LordDarkula LordDarkula changed the title Implement cleaner page referesh when page is clicked Implement cleaner page refresh when page is clicked Sep 15, 2016
@leegabriel
Copy link
Collaborator

leegabriel commented Sep 15, 2016

Glad you're thinking about UX so early, haha.

It might even be simpler and more accurate to just say href="/", since I believe clicking on Home should actually go to the home page instead of refreshing the current page.

@LordDarkula
Copy link
Contributor Author

I tried that. It did not work. Would you rather have home go to current page or just refresh?

@leegabriel
Copy link
Collaborator

leegabriel commented Sep 15, 2016

Oh, ok. Alternatively you can also try href="index.html". Wendy kind of split up the website into two websites previously but it's really up to Avinash and Alie how they would like the site... I think in any case, clicking the home button should actually take users to the home page.

I originally intended for this to be a single page website, hence the smooth scroll stuff, so I didn't really think about what would happen if the site doubled as a club website. Hopefully someone can sort that out, haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants