-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump vike #44
bump vike #44
Conversation
I'm trying to fix this, there are other issues when trying to build other examples too. |
Yes, it requires a couple of new features on Vike's side. I'll work on it next week. |
What course of action should we take on those?
It seems to be there to set
It seems to be here to check if the Vike's |
I realize that we have many discrepancies between current We should probably have some sort of consolidation between the 2 (and future ones). I was planning to extract |
Agreed. The overall plan here is to make It's actually one of the goals of my current config refactoring endeavour. I plan to turn |
7a68731
to
7571f88
Compare
7571f88
to
759ee08
Compare
Running
$ pnpm run build
inexamples/hono-react-cf-pages/
fails:At
packages/vike-node/src/plugin/plugins/edgePlugin.ts
:vitePluginSsr
no effectconfig.configVikePromise
doesn't exist