-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add compatibility with Vite 6 Environment API #2146
Conversation
Thank you for opening this early; so far there aren't any conflicts with my last refactoring. I'll be merging |
Btw. I should be done with my refactoring soon. The bulk of it is done, it's now "only" about small things. |
I'd suggest
I guess we don't need docs for it for now. It's mostly/only going to be used by our own extensions anyways. |
Your IDE seems to re-order imports. Can we revert these changes? We can eventually agree on some new linting rules after I merged all pending PRs & branches. |
Indeed, and I still don't know why, as the option is disabled :/ |
It seems like the IntelliJ Biome plugin does EDIT: Issue created |
# Conflicts: # pnpm-lock.yaml
884f71f
to
ff0b99d
Compare
You can do your refactoring @brillout. I do not know how I can manage to create a unit test with vite@5 in the same monorepo. Calling |
I see. Indeed I think we are currently not testing Vite 5 at all.
…On Fri 7. Feb 2025 at 16:58, Joël Charles ***@***.***> wrote:
You can do your refactoring @brillout <https://github.com/brillout>. I do
not know how I can manage to create a unit test with ***@***.*** in the same
monorepo. Calling vike build always use the Vite version in the linked
vike package. We could call vite build instead, but that doesn't seem
really wise.
—
Reply to this email directly, view it on GitHub
<#2146 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHVQRS4RUSY6HL4YFL3PV32OTJ2NAVCNFSM6AAAAABWTOFV6SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBTGMZDONZQG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
7b457a8
to
56f46a1
Compare
56f46a1
to
f197ca6
Compare
f197ca6
to
0956607
Compare
This reverts commit fdb1058c07e707a336fe2c5ad4a63ead34de4afb.
This reverts commit fed25c7a9c9f5a56eef1097ff740e702c722e3e7.
d296d91; let me know if that's an issue. |
This is a WIP to add Environment API compatibility, by calling
buildApp
instead ofvite.build
(keeping current behaviour as default).useEnvironmentAPI
viteEnvironmentAPI
config. Naming, location and whether it should be on the Vike CLI only -> to be discussedautoFullBuild
is disabled in this modevike:buildApp
plugins to mimicautoFullBuild