Update type definition for function
#177
Conversation
ryota2357
force-pushed
the
update-typedef
branch
from
108f4ba
to
200eaed
Compare
ryota2357
force-pushed
the
update-typedef
branch
3 times, most recently
from
671f4b3
to
c7f2209
Compare
denops_std/function/cursor_test.ts
Outdated
| @@ -46,6 +46,8 @@ test({ | |||
| assertNumber(await cursor.line(denops, ".")); | |||
| assertEquals(await cursor.line(denops, "."), 1); | |||
| assertEquals(await cursor.line(denops, "$"), 3); | |||
| assertNumber(await cursor.line(denops, ".", 1000)); | |||
| assertEquals(await cursor.line(denops, ".", 1000), 1); | |||
There was a problem hiding this comment.
should
We have no guarantee that the current winid is 1000. We need to get a correct one first.
There was a problem hiding this comment.
Fixed.
I changed to use bufwinid("%") to get current winid.
There was a problem hiding this comment.
It seems this part is not fixed yet.
There was a problem hiding this comment.
Sorry, I fixed it.
| export type PropAddListItem = [ | ||
| lnum: number, | ||
| col: number, | ||
| end_lnum: number, | ||
| end_col: number, | ||
| ]; |
There was a problem hiding this comment.
💭
I didn't know that we can annotate each tuple elements. Could you share the URL for this spec with me if you have one (This is just my interest so just ignore if you don't have it)
There was a problem hiding this comment.
It is from TypeScript 4.0.
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-0.html#labeled-tuple-elements
ryota2357
force-pushed
the
update-typedef
branch
from
c7f2209
to
0ec9c6b
Compare
denops_std/function/cursor_test.ts
Outdated
| @@ -46,6 +46,8 @@ test({ | |||
| assertNumber(await cursor.line(denops, ".")); | |||
| assertEquals(await cursor.line(denops, "."), 1); | |||
| assertEquals(await cursor.line(denops, "$"), 3); | |||
| assertNumber(await cursor.line(denops, ".", 1000)); | |||
| assertEquals(await cursor.line(denops, ".", 1000), 1); | |||
There was a problem hiding this comment.
It seems this part is not fixed yet.
ryota2357
force-pushed
the
update-typedef
branch
from
0ec9c6b
to
99065f8
Compare
#44
The minimum version supported by denops.vim has been raised, resulting in changes to the type definitions and documentation for some functions.
This PR is a update of the type definitions and documentation for those functions that were already typed.