Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform sentence style of terminal.jax #1677

Merged
merged 7 commits into from
Sep 15, 2024
Merged

Conversation

h-east
Copy link
Member

@h-east h-east commented Sep 4, 2024

Related: #812

Copy link
Contributor

@tsuyoshicho tsuyoshicho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

気付いた点についてコメント

doc/terminal.jax Outdated Show resolved Hide resolved
doc/terminal.jax Show resolved Hide resolved
doc/terminal.jax Show resolved Hide resolved
doc/terminal.jax Outdated Show resolved Hide resolved
Copy link
Member

@mityu mityu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L126 までみました。

doc/terminal.jax Outdated Show resolved Hide resolved
@mityu
Copy link
Member

mityu commented Sep 14, 2024

L391 まで見ました。ここまでは LGTM です。

doc/terminal.jax Outdated Show resolved Hide resolved
Co-authored-by: Tsuyoshi CHO <[email protected]>
Copy link
Member

@mityu mityu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2箇所変更漏れっぽいところに気づいたのでコメントしました。
どちらも行の整形込みで suggestion 作ろうとすると、対象となる範囲に行の追加と削除が入り混じることになって suggestion が作れないと言われてしまったので平文で失礼してます。

doc/terminal.jax Outdated Show resolved Hide resolved
doc/terminal.jax Outdated Show resolved Hide resolved
@mityu
Copy link
Member

mityu commented Sep 15, 2024

他は LGTM です 👍

@h-east h-east merged commit 407049f into master Sep 15, 2024
3 checks passed
@h-east h-east deleted the hh-uniform-style-terminal branch September 15, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants