Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home page UI change #703

Merged
merged 20 commits into from
Oct 15, 2024
Merged

Home page UI change #703

merged 20 commits into from
Oct 15, 2024

Conversation

KhawajaFashi
Copy link
Contributor

The new UI change that includes animation will increase the overall user experience and it will be appealing to the user

fixes #630

Before:

Screenshot (411)

After UI change:

Screenshot (412)

Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bobble-ai-rcmb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 0:41am

Copy link

👋 Thank you for opening this pull request! We're excited to review your contribution. Please give us a moment, and we'll get back to you shortly!

Feel free to join our community on Discord to discuss more!

@vimistify
Copy link
Owner

actually there are some changes as there is dark mode theme also added. can you make changes acc to that?

@vimistify
Copy link
Owner

and there are conflicts also.
Screenshot 2024-10-14 213834

@KhawajaFashi
Copy link
Contributor Author

actually there are some changes as there is dark mode theme also added. can you make changes acc to that?

Yes mam I considered that issue but the dark mode was not working so I skipped it for now if you want I can add the button then the functionality can be added later.

@KhawajaFashi
Copy link
Contributor Author

I will look into it.

and there are conflicts also.
Screenshot 2024-10-14 213834

@vimistify
Copy link
Owner

actually there are some changes as there is dark mode theme also added. can you make changes acc to that?

Yes mam I considered that issue but the dark mode was not working so I skipped it for now if you want I can add the button then the functionality can be added later.

its' added and translator also. so do changes accordingly. after that i can merged this.

@vimistify
Copy link
Owner

actually there are some changes as there is dark mode theme also added. can you make changes acc to that?

Yes mam I considered that issue but the dark mode was not working so I skipped it for now if you want I can add the button then the functionality can be added later.

its' added and translator also. so do changes accordingly. after that i can merged this.

there is assigned for translator. so do changes acc to that, after that. please. so that this pr don't make any blunder.

@KhawajaFashi
Copy link
Contributor Author

actually there are some changes as there is dark mode theme also added. can you make changes acc to that?

Yes mam I considered that issue but the dark mode was not working so I skipped it for now if you want I can add the button then the functionality can be added later.

its' added and translator also. so do changes accordingly. after that i can merged this.

there is assigned for translator. so do changes acc to that, after that. please. so that this pr don't make any blunder.

Yes mam I am looking into it solving the conflicts.

@KhawajaFashi
Copy link
Contributor Author

Sorry for the inconvenience earlier now everything is working as it should
https://github.com/user-attachments/assets/f10a345d-09f2-46a5-a3cb-542135dec059

@vimistify
Copy link
Owner

there are conflicts, resolve
Screenshot 2024-10-15 150206

@vimistify
Copy link
Owner

you made changes only on home? and features, contact, nearby, etc..

@KhawajaFashi
Copy link
Contributor Author

@mansiruhil13 i have resolved all the conflicts you can merge it now.
Screenshot (416)

@KhawajaFashi
Copy link
Contributor Author

KhawajaFashi commented Oct 15, 2024

you made changes only on home? and features, contact, nearby, etc..

Yes mam I wanted to synchronize this navbar design across all pages I just wanted to see if you liked the design then I can create the issue to synchronize on all pages

@vimistify
Copy link
Owner

Screenshot 2024-10-15 174716

@KhawajaFashi
Copy link
Contributor Author

KhawajaFashi commented Oct 15, 2024

@mansiruhil13 I think last code you merged raised the conflict because I have made changes to almost all of the page so it is sure to have a conflict if you merge some code.

@vimistify vimistify merged commit c3e6128 into vimistify:main Oct 15, 2024
2 checks passed
Copy link

🚀 Thank you for your contribution! This pull request has been closed. If you have any questions or need further assistance, feel free to reach out.

@vimistify
Copy link
Owner

you have to change on all pages. because now nav bar is different on all pages

@KhawajaFashi
Copy link
Contributor Author

you have to change on all pages. because now nav bar is different on all pages

Ok mam I will do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Home page UI change
2 participants