render do not overide link's target attribute close #370

vincent-peugnet · Dec 24, 2023 · 9c96b22 · 9c96b22
1 parent d9674c9
commit 9c96b22
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/app/class/Servicerender.php b/app/class/Servicerender.php
@@ -388,7 +388,7 @@ protected function htmlparser(string $html): string
             $href = $link->getAttribute('href');
             if (preg_match('~^https?:\/\/~', $href)) {
                 $classes[] = 'external';
-                if ($this->externallinkblank) {
+                if (!$link->hasAttribute('target') && $this->externallinkblank) {
                     $link->setAttribute('target', '_blank');
                 }
             } elseif (preg_match('~^([a-z0-9-_]+)((\/?#[a-z0-9-_]+)|(\/([\w\-\%\[\]\=\?\&]*)))?$~', $href, $out)) {
@@ -415,7 +415,7 @@ protected function htmlparser(string $html): string
                     $classes[] = 'existnot';
                     // TODO: store internal link that exist not in $this
                 }
-                if ($this->internallinkblank) {
+                if (!$link->hasAttribute('target') && $this->internallinkblank) {
                     $link->setAttribute('target', '_blank');
                 }
             // Links pointing to medias