config param to disable URL checker see #322

vincent-peugnet · Nov 25, 2024 · abf3add · abf3add
1 parent d6b8fff
commit abf3add
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 4 deletions.
diff --git a/app/class/Config.php b/app/class/Config.php
@@ -28,6 +28,7 @@ abstract class Config
     protected static bool $externallinkblank = true;
     protected static bool $internallinkblank = false;
     protected static bool $urllinker = true;
+    protected static bool $urlchecker = true;
     protected static bool $deletelinktocache = true;
     protected static int $defaultprivacy = 0;
     protected static string $homepage = 'default';
@@ -297,6 +298,11 @@ public static function urllinker(): bool
         return self::$urllinker;
     }
 
+    public static function urlchecker(): bool
+    {
+        return self::$urlchecker;
+    }
+
     public static function deletelinktocache(): bool
     {
         return self::$deletelinktocache;
@@ -536,6 +542,11 @@ public static function seturllinker($urllinker)
         self::$urllinker = boolval($urllinker);
     }
 
+    public static function seturlchecker($urlchecker)
+    {
+        self::$urlchecker = boolval($urlchecker);
+    }
+
     public static function setdeletelinktocache($deletelinktocache)
     {
         self::$deletelinktocache = boolval($deletelinktocache);

diff --git a/app/class/Controllerhome.php b/app/class/Controllerhome.php
@@ -94,6 +94,7 @@ public function desktop()
             $vars['deepsearch'] = $deepsearch['regex'];
             $vars['searchopt'] = $deepsearch['searchopt'];
             $vars['display'] = $display;
+            $vars['urlchecker'] = Config::urlchecker();
 
             if ($display === 'graph') {
                 $vars['layout'] = $_GET['layout'] ?? 'cose-bilkent';
@@ -327,7 +328,7 @@ public function multiedit()
     public function multirender(): void
     {
         $pagelist = $_POST['pagesid'] ?? [];
-        $checkurl = boolval($_POST['checkurl']);
+        $checkurl = Config::urlchecker() && boolval($_POST['checkurl']);
         $total = count($pagelist);
         $pagelist = $this->pagemanager->pagelistbyid($pagelist);
         $count = 0;

diff --git a/app/class/Controllerpage.php b/app/class/Controllerpage.php
@@ -75,7 +75,8 @@ public function render(string $page): void
 
         if ($this->importpage() && $this->user->iseditor()) {
             try {
-                $this->page = $this->pagemanager->renderpage($this->page, $this->router, new Serviceurlchecker(8));
+                $urlchecker = Config::urlchecker() ? new Serviceurlchecker(8) : null;
+                $this->page = $this->pagemanager->renderpage($this->page, $this->router, $urlchecker);
             } catch (RuntimeException $e) {
                 Logger::errorex($e);
             }
@@ -186,7 +187,8 @@ public function read(string $page): void
                 $oldlinkto = $this->page->linkto();
             }
             try {
-                $this->page = $this->pagemanager->renderpage($this->page, $this->router, new Serviceurlchecker(3));
+                $urlchecker = Config::urlchecker() ? new Serviceurlchecker(8) : null;
+                $this->page = $this->pagemanager->renderpage($this->page, $this->router, $urlchecker);
             } catch (RuntimeException $e) {
                 Logger::errorex($e);
             }

diff --git a/app/view/templates/admin.php b/app/view/templates/admin.php
@@ -287,6 +287,17 @@
             <input type="checkbox" name="internallinkblank" id="internallinkblank" value="1" <?= Wcms\Config::internallinkblank() ? 'checked' : '' ?> form="admin">
         </p>
 
+        <p class="field">
+            <input type="hidden" name="urlchecker" value="0" form="admin">
+            <label for="urlchecker">Enalbe URL checker</label>
+            <input type="checkbox" name="urlchecker" id="urlchecker" value="1" <?= Wcms\Config::urlchecker() ? 'checked' : '' ?> form="admin">
+        </p>
+
+        <p class="info">
+            URL checker try to reach URLs online to see if they are alives.
+            This may cause longer render time if recently activated.
+        </p>
+
         <h3>Markdown Parser</h3>
 
         <p class="field">

diff --git a/app/view/templates/home.php b/app/view/templates/home.php
@@ -32,7 +32,8 @@
         'colors' => $colors,
         'queryaddress' => $queryaddress,
         'matchedbookmarks' => $matchedbookmarks,
-        'editablebookmarks' => $editablebookmarks
+        'editablebookmarks' => $editablebookmarks,
+        'urlchecker' => $urlchecker,
     ]);
 ?>