Switching templates logic style #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch (no re-indent)
…ch (with re-indent!)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## ui-refresh #454 +/- ##
=============================================
Coverage ? 18.01%
Complexity ? 2020
=============================================
Files ? 72
Lines ? 5484
Branches ? 0
=============================================
Hits ? 988
Misses ? 4496
Partials ? 0 |
|
Awesome !!! mmh, I think I should rebase this branche on EDIT: solved this with the help of Nicolas |
vincent-peugnet
force-pushed
the
ui-refresh
branch
from
60a39c1 to
7de66bc
Compare
vincent-peugnet
requested changes
Oct 19, 2024
Co-authored-by: Nicolas Peugnet <[email protected]>
vincent-peugnet
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching templates logic style to if:else:endif and foreach:endforeach.
The first commit did no re-indentation, but for some files, I felt necessary to do some (which lead to quite complex diffs).